Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upload artifacts in PR build #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

eteq
Copy link
Contributor

@eteq eteq commented Apr 14, 2022

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

This PR adds the upload artifact stage to the PR workflow (but not the actual deploy, of course), so that we can see the rendered version of a notebook before it's merged. This could be thought of as a first step of #532 (although that needs more before I think we would consider it closed - see the discussion there).

Note the second commit here should be removed before merging - that's just to trigger the actual build process on one of the notebooks. So the intent is to back out that last commit before merging (although it leaves an unnecessary comment).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@eteq eteq requested a review from adrn April 14, 2022 15:57
@adrn
Copy link
Contributor

adrn commented Aug 12, 2022

@eteq This is fine with me! Can you remove the noop commit and then we can merge?

@adrn adrn force-pushed the upload-artifacts branch from 2ac4b25 to 1ca338f Compare August 16, 2022 11:55
Copy link
Contributor

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the commit for ya - thanks!

@adrn adrn merged commit b51054d into astropy-learn:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants