Upload artifacts in PR build #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the upload artifact stage to the PR workflow (but not the actual deploy, of course), so that we can see the rendered version of a notebook before it's merged. This could be thought of as a first step of #532 (although that needs more before I think we would consider it closed - see the discussion there).
Note the second commit here should be removed before merging - that's just to trigger the actual build process on one of the notebooks. So the intent is to back out that last commit before merging (although it leaves an unnecessary comment).