Fix SyntaxWarning: invalid escape sequence '\e'#911
Open
Avasam wants to merge 1 commit intoasweigart:masterfrom
Open
Fix SyntaxWarning: invalid escape sequence '\e'#911Avasam wants to merge 1 commit intoasweigart:masterfrom
SyntaxWarning: invalid escape sequence '\e'#911Avasam wants to merge 1 commit intoasweigart:masterfrom
Conversation
cclauss
reviewed
Oct 26, 2025
| '\t': _display.keysym_to_keycode(Xlib.XK.string_to_keysym('Tab')), | ||
| '\n': _display.keysym_to_keycode(Xlib.XK.string_to_keysym('Return')), # for some reason this needs to be cr, not lf | ||
| '\r': _display.keysym_to_keycode(Xlib.XK.string_to_keysym('Return')), | ||
| '\e': _display.keysym_to_keycode(Xlib.XK.string_to_keysym('Escape')), |
There was a problem hiding this comment.
This should be a raw string.
r'\e': _display.keysym_to_keycode(Xlib.XK.string_to_keysym('Escape')),Use r'\e' instead of '\e'.
Author
There was a problem hiding this comment.
Pretty sure not.
The string for the escape key is esc (see higher in the list). This meant to use a special character, but \e does not resolve to anything in Python.
There are no strings in the mapping actually starting with a raw \.
There was a problem hiding this comment.
Please read ruff rule W605 and run ruff check --select=W605 --fix on that file.
Author
There was a problem hiding this comment.
I'm aware of how raw strings work, thank you.
I'm telling you I don't think r"\e" or "\\e" was a correct entry in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #423