Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better handle timeout #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

Better handle timeout #809

merged 1 commit into from
Oct 12, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Oct 12, 2020 •
edited
Loading

When timeout is not provided to the resolve function, calling blocking endpoint provides retries on idle requests.
While calling the stream function would requires to deal with it.

This PR + symfony/symfony#38518 should fixes #806

@jderusse jderusse merged commit 3beaf2e into async-aws:master Oct 12, 2020
@jderusse jderusse deleted the handle-timeout branch October 12, 2020 16:07
@jderusse
Copy link
Member Author

thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests with timeout are not retried.
2 participants
@jderusse @Nyholm