Merge pull request #91 from async-interop/disabling_invalid_watcher

trowski · web-flow · commit 9ab9e6a6bb40 · 2016-08-30T15:35:31.000-05:00
Allow disabling of invalid watchers
diff --git a/src/Loop.php b/src/Loop.php
@@ -237,8 +237,6 @@ public static function enable($watcherId)
      * @param string $watcherId The watcher identifier.
      *
      * @return void
-     *
-     * @throws InvalidWatcherException If the watcher identifier is invalid.
      */
     public static function disable($watcherId)
     {
diff --git a/src/Loop/Driver.php b/src/Loop/Driver.php
@@ -134,19 +134,18 @@ abstract public function onSignal($signo, callable $callback, $data = null);
     abstract public function enable($watcherId);
 
     /**
-     * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher.
+     * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST NOT fail,
+     * even if passed an invalid watcher.
      *
      * @param string $watcherId The watcher identifier.
      *
      * @return void
-     *
-     * @throws InvalidWatcherException If the watcher identifier is invalid.
      */
     abstract public function disable($watcherId);
 
     /**
      * Cancel a watcher. This will detatch the event loop from all resources that are associated to the watcher. After
-     * this operation the watcher is permanently invalid. Calling this function MUST never fail, even when passed an
+     * this operation the watcher is permanently invalid. Calling this function MUST NOT fail, even if passed an
      * invalid watcher.
      *
      * @param string $watcherId The watcher identifier.

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,6 @@ public static function enable($watcherId)`
`237`	`237`	`* @param string $watcherId The watcher identifier.`
`238`	`238`	`*`
`239`	`239`	`* @return void`
`240`		`- *`
`241`		`- * @throws InvalidWatcherException If the watcher identifier is invalid.`
`242`	`240`	`*/`
`243`	`241`	`public static function disable($watcherId)`
`244`	`242`	`{`