Allow disabling of invalid watchers #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,13 +134,12 @@ | |||
| abstract public function enable($watcherId); | |||
|
|
|||
| /** | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. | |||
| * Disable a watcher. Disabling a watcher MUST NOT invalidate the watcher. Calling this function MUST never fail, | |||
There was a problem hiding this comment.
I've copied from cancel() docs.
There was a problem hiding this comment.
Should probably fixed there as well. Otherwise you might miss the never since only MUST is bold.
229d2f3 to
b3fdfa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.
Following no dissent in the related issue, this should be merged in a few days if nobody else objects.