Bitbucket: start refactoring api versions #583
Conversation
| if not_json_response: | ||
| return response.content | ||
| if self.advanced_mode: | ||
| return response |
There was a problem hiding this comment.
Please pay attention!
In this place, the order of lines was messed and the 'else' block below ran in wrong cases
There was a problem hiding this comment.
Could you reverse that change, please?
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(Bitbucket, self).__init__(*args, **kwargs) | ||
| url = kwargs.pop('url', False) |
There was a problem hiding this comment.
This block should be in front of the base init. See #584.
| url = 'rest/keys/1.0/projects/{key}/ssh'.format(key=key) | ||
| else: | ||
| url = 'rest/keys/2.0/projects/{key}/ssh'.format(key=key) | ||
| resource = self.resource_url('projects/{key}/ssh'.format(key=key)) |
There was a problem hiding this comment.
Here ressource_url MUST not be used, url is .../rest/keys/... and not .../rest/api/...
| else: | ||
| url = 'rest/keys/2.0/projects/{project_key}/repos/{repo_key}/ssh'.format(project_key=project_key, | ||
| repo_key=repo_key) | ||
| resource = self.resource_url('projects/{project_key}/repos/{repo_key}/ssh'.format(project_key=project_key, |
There was a problem hiding this comment.
Also .../rest/keys/... and not .../rest/api/...
There was a problem hiding this comment.
thx, I just missed this part!
There was a problem hiding this comment.
Create a member function ressource_url_keys which does mealy the same as the ressource_url. I'll create a PR for this.
Start removing messy api versions