This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Scroll to selected diff line only if head of selection changes #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `componentDidUpdate` was being called when anonymous function props were updated, triggering scrolling at undesired times. Instead, now we specifically check to see if the relevant props have changed before scrolling. Admittedly, I'm not sure what the purpose of the `selectedLine` branch of the original conditional was for. I traced its addition back to the "open diff from editor" feature I added 8 months ago, but manual testing of that feature seems to work without it. So I'm removing it and hoping that no regression is introduced, and taking a mental note to write more informative commit messages in the future.
BinaryMuse
approved these changes
Jan 12, 2018
Yeah we've dropped that branch of the conditional entirely. Tbh it's still unclear why we needed it in the first place. And the conditional branch that uses it seems to be for the "Open diff from editor" feature, but removing it doesn't seem to break anything because the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
componentDidUpdatewas being called when anonymousfunction props were updated, triggering scrolling at undesired times.
Instead, now we specifically check to see if the relevant props have
changed before scrolling.
Fixes #1226
Fixes #884