Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

More recent commits RFC edits #1420

Merged
merged 3 commits into from
Apr 25, 2018
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Apr 25, 2018

Description of the Change

More edits. This time, no moving around, mostly adding mockups for:

  • Highlight un-pushed commits
  • Ballon

Applicable Issues

Continuation of #1318

@simurai
Copy link
Contributor Author

simurai commented Apr 25, 2018

Here a mockup for the "ballon":

ballon

Navigation button ("open" to a git show-ish pane item)

Is 👆 similar to the current FilePatchView? Showing a pane with a diff, but potentially including multiple files? Like on .com. Should that be part of a different RFC? Maybe once there is a log view that could also use it.

If so, I'm not so sure how useful the ballon is. The action buttons at the bottom could be in the context menu. It's maybe even quicker to click because you don't have to move with the mouse that far. The only benefit of the ballon would be to see the entire commit message and body. Is that enough?

Here another proposal:

  • Short term: Clicking on a recent commit opens the commit on .com (with diff and all the infos). Un-pushed commits can't be clicked, so they will have different styling as a hint.
  • Long term: Once we have a git show-ish pane, clicking on a recent commit opens the git show-ish pane directly (without ballon).

@simurai simurai changed the title More recent commits edits More recent commits RFC edits Apr 25, 2018
@smashwilson
Copy link
Contributor

Is 👆 similar to the current FilePatchView? Showing a pane with a diff, but potentially including multiple files? Like on .com. Should that be part of a different RFC? Maybe once there is a log view that could also use it.

👍 Pretty much exactly where we were going with this, I think.

And yeah, I agree with your assessment. We can move the buttons as-is to the pane item once it exists.

@smashwilson smashwilson merged commit 9b315ec into master Apr 25, 2018
@smashwilson smashwilson deleted the sm-more-recent-commits-edits branch April 25, 2018 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants