Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Give the "show more" button a left margin #1877

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

smashwilson
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Give the "show more" button a left margin so that it doesn't look smooshed against the commit message:

before

Alternate Designs

N/A

Benefits

after

Possible Drawbacks

N/A

Applicable Issues

Fixes #1874.

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@smashwilson smashwilson requested a review from a team January 3, 2019 14:50
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #1877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         196      196           
  Lines       10745    10745           
  Branches     1574     1574           
=======================================
  Hits         9803     9803           
  Misses        942      942
Impacted Files Coverage Δ
lib/github-package.js 68.09% <0%> (-0.39%) ⬇️
lib/git-shell-out-strategy.js 87.87% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eab9c...9b61d09. Read the comment docs.

@smashwilson smashwilson merged commit 1439973 into master Jan 3, 2019
@smashwilson smashwilson deleted the aw/show-more-spacing branch January 3, 2019 15:26
@smashwilson smashwilson mentioned this pull request Jan 3, 2019
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect spacing before "Show more" on a commit message
2 participants