This repository was archived by the owner on Dec 15, 2022. It is now read-only.
mentionable users fall back #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1888 +/- ##
==========================================
- Coverage 91.22% 91.21% -0.01%
==========================================
Files 196 196
Lines 10745 10747 +2
Branches 1574 1575 +1
==========================================
+ Hits 9802 9803 +1
- Misses 943 944 +1
Continue to review full report at Codecov.
|
annthurium
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
thanks for fixing this, @vanessayuenn !
Great example of writing just enough code to solve the problem.
Failing tests need to be fixed before merge, obvi, but other than that, ship it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1872
If
GithubLoginModelcannot retrieve mentionable users for whatever reason, we fall back to fillUserStorefrom recent git commit authors, so the co-author dropdown isn't left empty.