This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Minor tweaks to release process #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
- Coverage 92.14% 92.12% -0.02%
==========================================
Files 189 189
Lines 10809 10809
Branches 1581 1581
==========================================
- Hits 9960 9958 -2
- Misses 849 851 +2
Continue to review full report at Codecov.
|
annthurium
approved these changes
Feb 5, 2019
Previously we did the pre-release on master, which leaves room for master to move forward during QA testing. I just ran into this with the 0.25.0 release (which ended up being the 0.26.0 release due to these complications 😳).
smashwilson
suggested changes
Feb 6, 2019
docs/how-we-work.md
Outdated
| 1. Check if a release commit was created (`git log`). If one exists, remove it from the commit history (`git reset --hard <sha-prior-to-commit>`). | ||
| 1. Check if a release tag was created (`git tag`). If one exists, delete it (`git tag -d 0.${MINOR}.0`). | ||
| 1. Address the problem that interfered with publishing. | ||
| 1. Try to publish again with `apm publish minor`. | ||
| 9. _In your atom/github repository:_ create a release branch for this minor version with `git checkout -b 0.${MINOR}-releases`. Push it to atom/github. |
There was a problem hiding this comment.
This step should be deleted now, yeah?
| 9. _In your atom/github repository:_ create a release branch for this minor version with `git checkout -b 0.${MINOR}-releases`. Push it to atom/github. | ||
| 9. _In your atom/atom repository:_ update the version of the `"github"` entry beneath `packageDependencies` in `package.json` to match the published minor version. Run `script/build` to update `package-lock.json` files. Commit and push these changes. | ||
| 9. _In your atom/atom repository:_ checkout a new branch (`git checkout -b bump-github-${VERSION}`), update the version of the `"github"` entry beneath `packageDependencies` in `package.json` to match the published minor version. Run `script/build` to update `package-lock.json` files. Commit and push these changes. |
There was a problem hiding this comment.
Sidenote: you can get away with just running script/bootstrap instead of script/build. But script/build is safer because it actually runs through the final snapshotting and everything, so let's leave it like this.
smashwilson
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll update this with any other tweaks I come across as I walk through the rest of the release process
Notable changes:
Removed Atom CI verification step.
Rationale: This step was originally introduced to catch snapshotting problems, but we now have other measures for catching this. Specifically we have a CI job that runs on our atom/github PRs, and we do a local build of Atom with a pre-release package version as part of our release QA testing.
Cut release branch at the start.
Rationale: So that work can continue on master without interfering with the release process.
Added steps for handling when publishing fails (make sure to delete tag and get release commit out of commit history)
View rendered docs/how-we-work.md