This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
+ Coverage 93.37% 93.41% +0.03%
==========================================
Files 235 236 +1
Lines 13178 13196 +18
Branches 1892 1897 +5
==========================================
+ Hits 12305 12327 +22
+ Misses 873 869 -4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Display and edit the values of
git config user.email
andgit config user.name
in an interstitial panel in the Git tab. The Identity panel is shown automatically if either are blank (which would prevent you from performing most git operations successfully anyway). Otherwise, it can be triggered manually by clicking on your avatar image in the Git tab header.Screenshot
Alternate Designs
Some nice-to-haves that I opted not to include in this effort:
+noreply
address.Benefits
This unblocks one of the biggest pieces of missing functionality in the "getting started" path. Setting these values is necessary for doing anything related to git, but requires either a separate local git installation or hand-editing a config file in a way that isn't well communicated.
With this in place, it will be possible to download Atom onto an otherwise vanilla machine and get started working with version control.
Possible Drawbacks
I still anticipate a fair amount of confusion related to the differences among:
These are three different things and can all be changed independently! I'd love to find a way to unify them somehow, at least by default, or better communicate which is applicable where.
Applicable Issues
Fixes #932 at long last. The next big chunk of #1934.
Release Notes
user.email
oruser.name
are not set, the Git tab will prompt for them to be populated.user.email
anduser.name
used to author git commits.