This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Ensure that activating a DockItem shows the corresponding Dock #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like there must be a better way to do this. 😑 |
smashwilson
approved these changes
May 11, 2017
lib/views/dock-item.js
Outdated
| @@ -109,6 +109,11 @@ export default class DockItem extends React.Component { | |||
| const pane = this.props.workspace.paneForItem(this.dockItem); | |||
| if (pane) { | |||
| pane.activateItem(this.dockItem); | |||
| const dock = this.props.workspace.getPaneContainers() | |||
| .find(container => container.getPanes().find(p => p.getItems().includes(this.dockItem))); | |||
| if (dock && dock.constructor.name === 'Dock') { | |||
There was a problem hiding this comment.
It might be better to probe for the method directly rather than using the constructor name:
dock && dock.show && dock.show();
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#673 made it show the Dock items are shown on first launch; however, the right Dock defaults to closed. This changes it so when we
activatethe item, it also shows the Dock.