Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Choose the active context by the active item in the workspace center #847

Merged
merged 2 commits into from
May 18, 2017

Conversation

smashwilson
Copy link
Contributor

@smashwilson smashwilson commented May 18, 2017

Now that the Docks API is shipped, the Workspace's active item can be either a pane item in the Workspace center or an item in one of the three Docks. This includes items which were previously Panels, like the tree view or our own Git- and GithubTabControllers. As none of these implement the "active context" pane API, moving focus to any of these causes the context resolution algorithm to fall back on the added projects, which doesn't always work as expected if there are zero or many projects in the workspace.

This will fixes #825 and issues like it in several layers by:

  • Inferring the active context from an active item in the Workspace center if the active pane item doesn't implement the context API
  • Implementing the context API for the Git and GithubTabControllers so that clicking on one of our own dock items never causes an active context switch

@smashwilson smashwilson merged commit 5fa4cde into master May 18, 2017
@smashwilson smashwilson deleted the aw-preserve-context branch May 18, 2017 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: can not interact with the panes when opening a file via advanced-open-file
1 participant