Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Updating CSS property list #173

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Updating CSS property list #173

merged 1 commit into from
Jul 19, 2021

Conversation

cssinate
Copy link
Contributor

@cssinate cssinate commented Feb 10, 2021 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

VSCode will be switching back to using this version of the CSS grammar shortly. However, there are a few minor discrepancies between the version they were using and this one. This is one of two PRs that takes the relevant changes from that grammar and applies it to Atom's. In this PR, I've adjusted the list of properties. For the reviewer's convenience, I've included a property-by-property diff at the end of this description. All of the props added were either on the list of MDN's CSS Reference or their list of SVG Presentation Attributes. SVG Presentation Attributes can be set in CSS.

Alternate Designs

N/A

Benefits

A more up-to-date list of CSS properties

Possible Drawbacks

None foreseeable

Applicable Issues

microsoft/vscode#115480

A diff of the property names:

+ backdrop-filter
+ bleed
+ border-end-end-radius
+ border-end-start-radius
+ border-start-end-radius
+ border-start-start-radius
+ caret-color
+ clip-rule
+ color-adjust
+ color-interpolation-filters
+ contain
+ enable-background
+ fallback
+ fill
+ fill-opacity
+ fill-rule
+ flood-color
+ flood-opacity
+ font-optical-sizing
+ font-variation-settings
+ gap
+ glyph-orientation-horizontal
+ glyph-orientation-vertical
+ hanging-punctuation
+ initial-letter
+ initial-letter-align
+ inset
+ inset-block
+ inset-block-end
+ inset-block-start
+ inset-inline
+ inset-inline-end
+ inset-inline-start
+ kerning
+ lighting-color
+ line-clamp
+ marker-end
+ marker-mid
+ marker-start
+ marks
+ mask
+ mask-border
+ mask-border-mode
+ mask-border-outset
+ mask-border-repeat
+ mask-border-slice
+ mask-border-source
+ mask-border-width
+ max-lines
+ offset
+ offset-anchor
- offset-block-end
- offset-block-start
+ offset-distance
- offset-inline-end
- offset-inline-start
+ offset-path
+ offset-position
+ offset-rotation
+ overflow-anchor
+ overflow-block
+ overflow-inline
+ overscroll-behavior
+ overscroll-behavior-block
+ overscroll-behavior-inline
+ overscroll-behavior-[xy]
+ paint-order
+ rotate
+ scale
+ scroll-margin
+ scroll-margin-block
+ scroll-margin-block-end
+ scroll-margin-block-start
+ scroll-margin-bottom
+ scroll-margin-inline
+ scroll-margin-inline-end
+ scroll-margin-inline-start
+ scroll-margin-left
+ scroll-margin-right
+ scroll-margin-top
+ scroll-padding
+ scroll-padding-block
+ scroll-padding-block-end
+ scroll-padding-block-start
+ scroll-padding-bottom
+ scroll-padding-inline
+ scroll-padding-inline-end
+ scroll-padding-inline-start
+ scroll-padding-left
+ scroll-padding-right
+ scroll-padding-top
+ scroll-snap-align
+ scroll-snap-stop
+ scrollbar-color
+ scrollbar-gutter
+ scrollbar-width
+ shape-rendering
+ size
+ stop-color
+ stop-opacity
+ stroke
+ stroke-dasharray
+ stroke-dashoffset
+ stroke-linecap
+ stroke-linejoin
+ stroke-miterlimit
+ stroke-opacity
+ stroke-width
+ text-anchor
+ text-decoration-skip
+ text-decoration-skip-ink
+ text-justify
+ text-size-adjust
+ translate
+ user-select

@cssinate cssinate changed the title Updating CSS propertly list Updating CSS property list Feb 10, 2021
This was referenced Feb 10, 2021
Closed
Closed
@cssinate
Copy link
Contributor Author

@darangi - someone on Discord suggested I mention you here to please take a look at this and #174. VSCode is waiting for these two tickets to be merged before they update their reference to atom/language-css. Would you mind taking a look please? Thanks!

@darangi
Copy link
Contributor

darangi commented Feb 20, 2021

Hi @cssinate thanks! The team will take a look

sadick254
sadick254 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cssinate Thank you for adding the properties.

@sadick254 sadick254 merged commit 033087e into atom:master Jul 19, 2021
cssinate referenced this pull request in microsoft/vscode Jul 19, 2021
@alexr00
Try new CSS grammar
bc405e9 
Fixes #115480
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadick254 sadick254 sadick254 approved these changes

Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cssinate @darangi @sadick254