You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for block formats in format_texel_block_size(), copy_buffer_to_image_regions(), copy_image_to_buffer_regions(). Added format_texel_block_dimensions().
I broke ImageInfo tests while trying to fix an issue I ran into doing gpu-culled depth pyramid cubes for point shadow rendering. The root issue was that Screen-13 has invented a new way of describing cube images that differs from the spec, and while that might make it easier to understand these images without prior knowledge, it greatly complicates any understanding that you bring to Screen-13 or while adapting other examples.
The fix, although it will take a new version, is to finally remove screen_13::driver::image::ImageType and let users rely on vk::ImageType. I'll push this branch soon.
I only mention that because I would like to make this crate easier to use and I'm finding it's the little things that impede this goal. To that end, could we rename format_texel_block_dimensions -> format_texel_block_extent?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for block formats in
format_texel_block_size(),copy_buffer_to_image_regions(),copy_image_to_buffer_regions(). Addedformat_texel_block_dimensions().Added remaining formats in https://registry.khronos.org/vulkan/specs/latest/html/vkspec.html#texel-block-size
Have only tested with BCn textures.