Fix: Attempted write update to an immutable sampler descriptor. #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for debugging and fixing this! After re-reviewing #72 I'm wondering why I decided to merge without fixing this. I do recall hitting this exact problem while making the change. At one point I was going to allow submitting dynamic samplers using the render graph, but the code is left in a half-way state in between these ideas. Making things worse, there are additional validation errors introduced with the latest Vulkan SDK which are fixed on an unpublished branch based on #75, so there will be errors related to swapchain and uint8 regardless. One tiny edit I'll make is that the entire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image_sampler example with
--separate(with either hlsl or glsl) was resulting in this vulkan validation error:It was also crashing if run in render doc.
I think the sampler does not need to be updated in the descriptor binding in this case since it is already included immutably.
Sorry it took me so long to get around to testing this. Thanks so much for implementing it! Besides this issue it seems to be working great!