Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@attackgoat
Copy link
Owner

Fixes a segfault on Mac when resizing the window by doing two innocuous but otherwise "good" things:

  1. Provide the old swapchain when recreating a new swapchain
  2. Wait for a successful present before destroying the old swapchain

The issue was easy to reproduce by taking any example and dragging the window around; after 5-10s it would happen.

Also removes the vk::Result::SUBOPTIMAL_KHR error case during acquire_next_image() because ash never returns it.

@attackgoat attackgoat merged commit 7001998 into master Feb 24, 2025
3 checks passed
@attackgoat attackgoat deleted the swapchain-destroy branch February 24, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants