fix: remove debug assert for desired image count and set_var fix #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve more images than desired
Contributor
Author
|
I also added the unsafe blocks around set_var, since this is mandatory for rust edition 2024 |
Owner
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan can always return more images than provided in
.min_image_count(..).Ref: https://gitlab.freedesktop.org/apinheiro/mesa/-/issues/9
Quotes by a comment in that issue:
From the Vulkan spec: minImageCount is the minimum number of presentable images that the application needs. The implementation will either create the swapchain with at least that many images(...)