Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add "System default" option for audio devices, and ensure audio plays through new device when unpausing#10255

Open
ndbroadbent wants to merge 2 commits intoaudacity:masterfrom
ndbroadbent:feature/system-default-device
Open

Add "System default" option for audio devices, and ensure audio plays through new device when unpausing#10255
ndbroadbent wants to merge 2 commits intoaudacity:masterfrom
ndbroadbent:feature/system-default-device

Conversation

@ndbroadbent
Copy link

@ndbroadbent ndbroadbent commented Jan 21, 2026 •
edited
Loading

Resolves: #8281, #9443

Related: #9151, #9172

Adds a “System default” audio device option and keeps Audacity synced to system device changes across platforms. Unifies Preferences and Audio Setup device selection through the same action path, disables device changes while playing/recording, and preserves paused playhead position when switching devices.

New system default option in Preferences:

image

New system default option in Audio Setup device selection:

image

Disable Audio Setup device selection during playback (to match behavior of preferences)

image
  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

QA:

  • Autobot test cases have been run

UPDATE: I also added some additional tests.

This was referenced Jan 21, 2026
Open
Open
@ndbroadbent ndbroadbent force-pushed the feature/system-default-device branch from 4213d54 to d241aaa Compare January 22, 2026 03:36
@ndbroadbent
Copy link
Author

ndbroadbent commented Jan 22, 2026 •
edited
Loading

I ran the coderabbit CLI to review the changes, and implemented all the suggestions until it had no further comments.

❯ coderabbit review --base master --plain
Starting CodeRabbit review in plain text mode...

Connecting to review service
Setting up
Analyzing
Reviewing

Review completed ✔

(no issues found)

@ndbroadbent ndbroadbent force-pushed the feature/system-default-device branch from d241aaa to fba2e1c Compare January 22, 2026 03:38
@ndbroadbent ndbroadbent force-pushed the feature/system-default-device branch from ba41786 to ee3f58e Compare January 22, 2026 13:29
@kryksyh kryksyh requested a review from luapmartin January 23, 2026 07:28
@kryksyh
Copy link
Member

kryksyh commented Jan 23, 2026

@ndbroadbent thanks! Looks good at first glance.

@ndbroadbent
Copy link
Author

ndbroadbent commented Jan 23, 2026 •
edited
Loading

Apologies for the CI failures, I'm running the CI steps locally now and fixing the code style warning

EDIT: I pushed those fixes

@ndbroadbent
Add system-default device tests and dispatch coverage
8c34deb 
Add au3audio/playback/preferences tests for system default selection and paused restart actions, and silence CoreAudio element deprecation on macOS.
@ndbroadbent ndbroadbent force-pushed the feature/system-default-device branch from ee3f58e to 8c34deb Compare January 23, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luapmartin luapmartin Awaiting requested review from luapmartin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a 'System default' option to playback device preference

2 participants

@ndbroadbent @kryksyh