Exposed OTP secret for not-yet serialised Transaction entities #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw OTP secret is required for enrollments on devices without cameras, as well as on devices that have damaged/broken cameras. Authy, Google Authenticator and Microsoft Authenticator all permit manual entry of the Base32-encoded secret, and we'd like to support that for our users.
While the TOTP URI's structure is dictated by a standard, it feels pretty dirty to decode a string that was encoded milliseconds previously, and there is no security benefit to concealing the raw secret.