Uses Python built-in modules to retrieve Python and auth0-python version number#125
Merged
Conversation
lbalmaceda
suggested changes
Oct 5, 2018
Contributor
lbalmaceda
left a comment
There was a problem hiding this comment.
Thanks. The class was missing tests to cover the telemetry header. Would you mind adding at least one that asserts that the Auth0-Client header is present and with the correct value? Should be located on the auth0/v3/test/management/test_rest.py file
Author
|
Okay, I'll add the test. Please wait. |
Author
|
@lbalmaceda please review the added test. Thanks! |
Contributor
|
Looks good. Thanks for the changes. I've found that the Auth calls are missing Telemetry too and created an issue to track this. Since it's similar to what you've done, feel free to take it 👌 #136 |
lbalmaceda
approved these changes
Oct 8, 2018
Author
|
@lbalmaceda Thank you for the merge. I think I'll pass on the opportunity, but thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.