Add client_id param to ClientGrants.all#159
Merged
Merged
Conversation
Contributor
Author
|
@lbalmaceda could you please review this when you get time? I'm not sure whether it is complete. |
joshcanhelp
suggested changes
Nov 5, 2018
Contributor
There was a problem hiding this comment.
Looks good @danishprakash! A few minor things in the PR here and happy to get this merged in. Also, there is a merge conflict you'll want to look into as well.
Contributor
Author
|
@joshcanhelp thank you, have made the changes you requested and also resolved the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76