Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rules_config.unset fix #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2019
Merged

rules_config.unset fix #195

merged 2 commits into from
May 10, 2019

Conversation

jhunken
Copy link
Contributor

@jhunken jhunken commented May 10, 2019

Changes

Changes rules_config.unset to pass the key param as a path param instead of a query param. This fixes the 404 error previously being returned.

References

Closes #194

Testing

Fixed existing unittest.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jhunken jhunken requested a review from a team May 10, 2019 17:51
@lbalmaceda lbalmaceda merged commit a2706a5 into auth0:master May 10, 2019
@lbalmaceda lbalmaceda added this to the v3-Next milestone May 10, 2019
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.8.0 Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

rules_config.unset does not work
3 participants
@jhunken @damieng @lbalmaceda