Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adds a new user method invalidate_remembered_browsers#248

Merged
lbalmaceda merged 2 commits into
auth0:masterfrom
kpurdon:kpurdon/add-user-invalidate-remember-browsers
Dec 22, 2020
Merged

Adds a new user method invalidate_remembered_browsers#248
lbalmaceda merged 2 commits into
auth0:masterfrom
kpurdon:kpurdon/add-user-invalidate-remember-browsers

Conversation

@kpurdon
Copy link
Copy Markdown
Contributor

@kpurdon kpurdon commented Nov 25, 2020

Changes

Please describe both what is changing and why this is important. Include:

  • Adds a missing endpoint to invalidate all remembered browsers (mfa) for a user

References

https://auth0.com/docs/api/management/v2#!/Users/post_invalidate_remember_browser

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kpurdon kpurdon requested a review from a team as a code owner November 25, 2020 23:00
@kpurdon
Copy link
Copy Markdown
Contributor Author

kpurdon commented Dec 2, 2020

@lbalmaceda from issues it looks like your the correct person to check in with on this (LMK if that's not the case). Anything I can do to get this reviewed? Thanks!

Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor request around the value used as input in the tests.

Comment thread auth0/v3/test/management/test_users.py Outdated
Comment thread auth0/v3/test/management/test_users.py Outdated
@lbalmaceda lbalmaceda added this to the v3-Next milestone Dec 22, 2020
@lbalmaceda lbalmaceda added the small Small review label Dec 22, 2020
@lbalmaceda lbalmaceda merged commit e1adcbe into auth0:master Dec 22, 2020
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.14.0 Dec 22, 2020
@kpurdon kpurdon deleted the kpurdon/add-user-invalidate-remember-browsers branch December 22, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CH: Added small Small review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants