Update pre-commit and CircleCI config
#473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46a634d to
f2ba729
Compare
Update `CircleCI` config, to run `pre-commit` on python>=3.8 Update `pyupgrade` to last version (`3.3.1`) Update `black` to last version (`23.1.0`) and apply code formatting Update `isort` to last version (`5.12.0`), fixing build fail with `pre-commit` Update `flake8` to last version (`6.0.0`)`
25d1d52 to
fa9f239
Compare
pre-commit configpre-commit and CircleCI config
adamjmcgrath
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CircleCIconfig, to runpre-commitonly on supported python versions (>=3.8)Update
pyupgradeto last version (3.3.1)Update
blackto last version (23.1.0) and apply code formattingUpdate
isortto last version (5.12.0), fixing build fail withpre-commitUpdate
flake8to last version (6.0.0)ci was failing because of
isort, see PyCQA/isort@0d219a6I think we can even run
pre-commitonly on a single python version, lint results are probably the same across Python versions