Remove ds store #78
Merged
Remove ds store #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-c-p
approved these changes
Oct 14, 2017
There was a problem hiding this comment.
Yes, I think ignoring all the .DS_Store files is a good idea because:
- a possible scenario where another contributor (who is using Mac) gets her/his PR accepted, then sensitive info of her/him may become public (as it is now the contributor's
.DS_Storethat every other contributor has in their working directory) without anyone realizing. - This is file system specific, if a vindows user clones this repo, s/he might panic what's in
.DS_Storenot to mention the hiccups Redmond's OS may have - for those using a Mac, periodic changes in working directory will be reflected in
.DS_Store, and since the file is binary format, it will makegit pushslow irrespective of internet speed - we just don't need to see this, it makes me conscious that I don't have a sexy Mac laptop, to work on, yet :P
(I wanted to submit this change as my first contribution to open source, but I was 9 days late, anyway, I hope this thing gets merged)
ravoro
suggested changes
Oct 21, 2017
.gitignore
Outdated
| @@ -50,3 +50,5 @@ docs/_build/ | |||
| # IDEA | |||
| .idea/ | |||
| *.iml | |||
|
|
|||
| .DS_Store | |||
There was a problem hiding this comment.
@georgeyk To follow the format of the rest of the file, maybe put a category comment, such as "OS-specific files" or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor clean-up