propagate errors from tokio::tasks and make am windows compatible
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatchan
reviewed
Jun 20, 2023
| biased; | ||
|
|
||
| Ok(()) | ||
| _ = tokio::signal::ctrl_c() => { |
Contributor
There was a problem hiding this comment.
This is already working fine in the current version, which also propagates the sigint to the prometheus process. So we can probably get rid of this. (though that was in the tokio::spawn situation)
Contributor
Author
There was a problem hiding this comment.
this is cuz select will abort all other tasks when one finishes, so we want to await the ctrl c signal so we have correct shutting down
hatchan
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
fixes #35