Logging and exception handling improvements #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `manage.py` script gets its log level from the env var `LOG_LEVEL` which we set manually in testing, but this doesn't effect ContainerPilot logging. This commit updates the ContainerPilot configuration to also use the `LOG_LEVEL` env var, defaulting to INFO.
For #45. We can't run the tests in the build container because that's on Python3 and the `bin/manage.py` application is still on Python2, but that might be a good idea in the future.
Also makes sure unit-test gets help string in makefile
Contributor
Author
|
@misterbisson I think this is ready for review if you get a sec. |
Contributor
|
:pickles: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #30
Includes:
make build tag test-local-dockerw/o shipping to the Docker HubLOG_LEVELenv var that themanage.pyscript does