Fix Consul --retry-join failure #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jasonpincin
reviewed
Dec 9, 2016
| -ui-dir /ui | ||
| image: consul:0.7.1 | ||
| command: > | ||
| agent -server -client=0.0.0.0 -bootstrap -ui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for problems discovered with Consul clustering as part of debugging #71.
The Consul server was continually trying to join itself because I switched it to use autopilotpattern/consul when it's only a single-node cluster.
Also, when we reload the config for the primary, the logic in manager/containerpilot.py includes the port 8500 in the
-retry-joinfield which it should not. So we join Consul just fine and then keep trying to re-join on a port that doesn't work after the reload.cc @misterbisson @jasonpincin @mbbender