initial implementation #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| Work in progress, not stable, expect force pushes of this repo | ||
| # Autopilot Pattern Postgres | ||
|
|
||
| Postgres designed for automated operation using the [Autopilot Pattern](http://autopilotpattern.io/). This repo serves as a blueprint demonstrating the pattern. |
There was a problem hiding this comment.
I think this could be restructured:
This repo serves as a blueprint demonstrating Postgres designed for automated operation using the Autopilot Pattern.
There was a problem hiding this comment.
Also, is it worth mentioning it's an extension of an official image and linking out to said image?
README.md
Outdated
| $ docker-compose scale db=3 | ||
| ``` | ||
|
|
||
| The first instance creates a Postgres master. All additional instances create read only replicas. |
There was a problem hiding this comment.
Read-only should have a hyphen.
Contributor
Author
|
@heyawhite I think I've addressed all of your comments. |
geek
reviewed
Aug 17, 2017
|
|
||
| ## Environment Variables | ||
|
|
||
| - `CONSUL`: consul hostname |
| @@ -0,0 +1,112 @@ | |||
| 'use strict'; | |||
| const Cp = require('child_process'); | |||
Contributor
There was a problem hiding this comment.
have you belly-button linted this?
Contributor
Author
There was a problem hiding this comment.
I haven't, but don't threaten me with a good time.
Contributor
|
After those 2 changes, LGTM! |
Contributor
Author
|
@geek updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.