Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Recognize typical assertion errors and use their formatting #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 24, 2023
Merged

Recognize typical assertion errors and use their formatting #3187

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
af320f9
:sparkles: Improve formatting external assert libs
Irvenae Mar 30, 2023
8225c6b
:heavy_plus_sign: add expect dep
Irvenae Apr 12, 2023
e14aa0a
:ribbon: lint
Irvenae Apr 12, 2023
6e121ef
:white_check_mark: update tests
Irvenae Apr 12, 2023
78c62f9
:white_check_mark: update tap reporters
Irvenae Apr 12, 2023
8a5b07c
:partly_sunny: improve error check
Irvenae Apr 12, 2023
82062a4
:white_check_mark: update tap reporters
Irvenae Apr 12, 2023
1c45b23
:ribbon: lint
Irvenae Apr 12, 2023
581c789
:white_check_mark: fix test
Irvenae Apr 17, 2023
40e6eee
duplicate hasOwnProperty
Irvenae Apr 17, 2023
5e52c46
:white_check_mark: fix windows test
Irvenae Apr 17, 2023
b6769f1
Test async codepath
novemberborn May 21, 2023
3e1d01b
Respect linting
novemberborn May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
✅ update tap reporters
  • Loading branch information
@Irvenae
Irvenae committed Apr 12, 2023
commit 78c62f98e3a5a78f5e9306819bc6ddd0709e28f4
4 changes: 0 additions & 4 deletions test-tap/reporters/default.edgecases.v16.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
---tty-stream-chunk-separator
Uncaught exception in ast-syntax-error.cjs

~/test-tap/fixture/report/edgecases/ast-syntax-error.cjs:3
const fn = do {
^^

SyntaxError: Unexpected token 'do'

---tty-stream-chunk-separator
Expand Down
26 changes: 16 additions & 10 deletions test-tap/reporters/default.regular.v14.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,21 @@
---tty-stream-chunk-separator
✘ [fail]: test › formatted
---tty-stream-chunk-separator
✘ [fail]: test › implementation throws non-error Error thrown in test
✘ Internal error when running test.cjs
TypeError: Cannot read property 'matcherResult' of null
TypeError: Cannot read property 'matcherResult' of null
 at isExternalAssertError (file://~/lib/test.js:12:12)
 at Test.run (file://~/lib/test.js:532:8)
 at Runner.runSingle (file://~/lib/runner.js:285:33)
 at Runner.runTest (file://~/lib/runner.js:367:30)
 at processTicksAndRejections (internal/process/task_queues.js:95:5)
 at async Promise.all (index 6)
 at async file://~/lib/runner.js:532:21
 at async Runner.start (file://~/lib/runner.js:540:15)


---tty-stream-chunk-separator
✘ test.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
✘ [fail]: traces-in-t-throws › throws
---tty-stream-chunk-separator
Expand Down Expand Up @@ -233,14 +247,6 @@



test › implementation throws non-error

Error thrown in test:

null



traces-in-t-throws › throws

traces-in-t-throws.cjs:12
Expand Down Expand Up @@ -348,7 +354,7 @@

─

13 tests failed
12 tests failed
1 known failure
1 test skipped
1 test todo
Expand Down
26 changes: 16 additions & 10 deletions test-tap/reporters/default.regular.v16.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,21 @@
---tty-stream-chunk-separator
✘ [fail]: test › formatted
---tty-stream-chunk-separator
✘ [fail]: test › implementation throws non-error Error thrown in test
✘ Internal error when running test.cjs
TypeError: Cannot read properties of null (reading 'matcherResult')
TypeError: Cannot read properties of null (reading 'matcherResult')
 at isExternalAssertError (file://~/lib/test.js:12:12)
 at Test.run (file://~/lib/test.js:532:8)
 at Runner.runSingle (file://~/lib/runner.js:285:33)
 at Runner.runTest (file://~/lib/runner.js:367:30)
 at processTicksAndRejections (node:internal/process/task_queues:96:5)
 at async Promise.all (index 6)
 at async file://~/lib/runner.js:532:21
 at async Runner.start (file://~/lib/runner.js:540:15)


---tty-stream-chunk-separator
✘ test.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
✘ [fail]: traces-in-t-throws › throws
---tty-stream-chunk-separator
Expand Down Expand Up @@ -233,14 +247,6 @@



test › implementation throws non-error

Error thrown in test:

null



traces-in-t-throws › throws

traces-in-t-throws.cjs:12
Expand Down Expand Up @@ -348,7 +354,7 @@

─

13 tests failed
12 tests failed
1 known failure
1 test skipped
1 test todo
Expand Down
26 changes: 16 additions & 10 deletions test-tap/reporters/default.regular.v18.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,21 @@
---tty-stream-chunk-separator
✘ [fail]: test › formatted
---tty-stream-chunk-separator
✘ [fail]: test › implementation throws non-error Error thrown in test
✘ Internal error when running test.cjs
TypeError: Cannot read properties of null (reading 'matcherResult')
TypeError: Cannot read properties of null (reading 'matcherResult')
 at isExternalAssertError (file://~/lib/test.js:12:12)
 at Test.run (file://~/lib/test.js:532:8)
 at Runner.runSingle (file://~/lib/runner.js:285:33)
 at Runner.runTest (file://~/lib/runner.js:367:30)
 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
 at async Promise.all (index 6)
 at async file://~/lib/runner.js:532:21
 at async Runner.start (file://~/lib/runner.js:540:15)


---tty-stream-chunk-separator
✘ test.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
✘ [fail]: traces-in-t-throws › throws
---tty-stream-chunk-separator
Expand Down Expand Up @@ -233,14 +247,6 @@



test › implementation throws non-error

Error thrown in test:

null



traces-in-t-throws › throws

traces-in-t-throws.cjs:12
Expand Down Expand Up @@ -348,7 +354,7 @@

─

13 tests failed
12 tests failed
1 known failure
1 test skipped
1 test todo
Expand Down
6 changes: 1 addition & 5 deletions test-tap/reporters/tap.edgecases.v16.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
TAP version 13
---tty-stream-chunk-separator
not ok 1 - ~/test-tap/fixture/report/edgecases/ast-syntax-error.cjs:3
const fn = do {
^^

SyntaxError: Unexpected token 'do'
not ok 1 - SyntaxError: Unexpected token 'do'
---
name: SyntaxError
message: Unexpected token 'do'
Expand Down
47 changes: 28 additions & 19 deletions test-tap/reporters/tap.regular.v14.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,25 @@ not ok 14 - test › formatted
at: 'test-tap/fixture/report/regular/test.cjs:22:4'
...
---tty-stream-chunk-separator
not ok 15 - test › implementation throws non-error
not ok 15 - TypeError: Cannot read property 'matcherResult' of null
---
name: AssertionError
message: Error thrown in test
values:
'Error thrown in test:': 'null'
at: ''
name: TypeError
message: Cannot read property 'matcherResult' of null
at: |-
TypeError: Cannot read property 'matcherResult' of null
at isExternalAssertError (file://~/lib/test.js:12:12)
at Test.run (file://~/lib/test.js:532:8)
at Runner.runSingle (file://~/lib/runner.js:285:33)
at Runner.runTest (file://~/lib/runner.js:367:30)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async Promise.all (index 6)
at async file://~/lib/runner.js:532:21
at async Runner.start (file://~/lib/runner.js:540:15)
...
---tty-stream-chunk-separator
not ok 16 - traces-in-t-throws › throws
not ok 16 - test.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
not ok 17 - traces-in-t-throws › throws
---
name: AssertionError
assertion: throws
Expand All @@ -163,7 +172,7 @@ not ok 16 - traces-in-t-throws › throws
test-tap/fixture/report/regular/traces-in-t-throws.cjs:12:4
...
---tty-stream-chunk-separator
not ok 17 - traces-in-t-throws › notThrows
not ok 18 - traces-in-t-throws › notThrows
---
name: AssertionError
assertion: notThrows
Expand All @@ -178,7 +187,7 @@ not ok 17 - traces-in-t-throws › notThrows
test-tap/fixture/report/regular/traces-in-t-throws.cjs:16:4
...
---tty-stream-chunk-separator
not ok 18 - traces-in-t-throws › notThrowsAsync
not ok 19 - traces-in-t-throws › notThrowsAsync
---
name: AssertionError
assertion: notThrowsAsync
Expand All @@ -193,7 +202,7 @@ not ok 18 - traces-in-t-throws › notThrowsAsync
test-tap/fixture/report/regular/traces-in-t-throws.cjs:20:4
...
---tty-stream-chunk-separator
not ok 19 - traces-in-t-throws › throwsAsync
not ok 20 - traces-in-t-throws › throwsAsync
---
name: AssertionError
assertion: throwsAsync
Expand All @@ -211,7 +220,7 @@ not ok 19 - traces-in-t-throws › throwsAsync
test-tap/fixture/report/regular/traces-in-t-throws.cjs:24:4
...
---tty-stream-chunk-separator
not ok 20 - traces-in-t-throws › throwsAsync different error
not ok 21 - traces-in-t-throws › throwsAsync different error
---
name: AssertionError
assertion: throwsAsync
Expand All @@ -228,9 +237,9 @@ not ok 20 - traces-in-t-throws › throwsAsync different error
test-tap/fixture/report/regular/traces-in-t-throws.cjs:27:44
...
---tty-stream-chunk-separator
ok 21 - uncaught-exception › passes
ok 22 - uncaught-exception › passes
---tty-stream-chunk-separator
not ok 22 - Error: Can’t catch me
not ok 23 - Error: Can’t catch me
---
name: Error
message: Can’t catch me
Expand All @@ -239,20 +248,20 @@ not ok 22 - Error: Can’t catch me
(test-tap/fixture/report/regular/uncaught-exception.cjs:5:9)
...
---tty-stream-chunk-separator
not ok 23 - uncaught-exception.cjs exited with a non-zero exit code: 1
not ok 24 - uncaught-exception.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
ok 24 - unhandled-rejection › passes
ok 25 - unhandled-rejection › passes
---tty-stream-chunk-separator
ok 25 - unhandled-rejection › unhandled non-error rejection
ok 26 - unhandled-rejection › unhandled non-error rejection
---tty-stream-chunk-separator
not ok 26 - Error: Can’t catch me
not ok 27 - Error: Can’t catch me
---
name: Error
message: Can’t catch me
at: 'passes (test-tap/fixture/report/regular/unhandled-rejection.cjs:4:17)'
...
---tty-stream-chunk-separator
not ok 27 - unhandled-rejection
not ok 28 - unhandled-rejection
---
message: Non-error object
formatted: 'null'
Expand All @@ -263,6 +272,6 @@ not ok 27 - unhandled-rejection
# tests 20
# pass 6
# skip 1
# fail 20
# fail 22

---tty-stream-chunk-separator
47 changes: 28 additions & 19 deletions test-tap/reporters/tap.regular.v16.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,25 @@ not ok 14 - test › formatted
at: 'test-tap/fixture/report/regular/test.cjs:22:4'
...
---tty-stream-chunk-separator
not ok 15 - test › implementation throws non-error
not ok 15 - TypeError: Cannot read properties of null (reading 'matcherResult')
---
name: AssertionError
message: Error thrown in test
values:
'Error thrown in test:': 'null'
at: ''
name: TypeError
message: Cannot read properties of null (reading 'matcherResult')
at: |-
TypeError: Cannot read properties of null (reading 'matcherResult')
at isExternalAssertError (file://~/lib/test.js:12:12)
at Test.run (file://~/lib/test.js:532:8)
at Runner.runSingle (file://~/lib/runner.js:285:33)
at Runner.runTest (file://~/lib/runner.js:367:30)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Promise.all (index 6)
at async file://~/lib/runner.js:532:21
at async Runner.start (file://~/lib/runner.js:540:15)
...
---tty-stream-chunk-separator
not ok 16 - traces-in-t-throws › throws
not ok 16 - test.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
not ok 17 - traces-in-t-throws › throws
---
name: AssertionError
assertion: throws
Expand All @@ -163,7 +172,7 @@ not ok 16 - traces-in-t-throws › throws
test-tap/fixture/report/regular/traces-in-t-throws.cjs:12:4
...
---tty-stream-chunk-separator
not ok 17 - traces-in-t-throws › notThrows
not ok 18 - traces-in-t-throws › notThrows
---
name: AssertionError
assertion: notThrows
Expand All @@ -178,7 +187,7 @@ not ok 17 - traces-in-t-throws › notThrows
test-tap/fixture/report/regular/traces-in-t-throws.cjs:16:4
...
---tty-stream-chunk-separator
not ok 18 - traces-in-t-throws › notThrowsAsync
not ok 19 - traces-in-t-throws › notThrowsAsync
---
name: AssertionError
assertion: notThrowsAsync
Expand All @@ -193,7 +202,7 @@ not ok 18 - traces-in-t-throws › notThrowsAsync
test-tap/fixture/report/regular/traces-in-t-throws.cjs:20:4
...
---tty-stream-chunk-separator
not ok 19 - traces-in-t-throws › throwsAsync
not ok 20 - traces-in-t-throws › throwsAsync
---
name: AssertionError
assertion: throwsAsync
Expand All @@ -211,7 +220,7 @@ not ok 19 - traces-in-t-throws › throwsAsync
test-tap/fixture/report/regular/traces-in-t-throws.cjs:24:4
...
---tty-stream-chunk-separator
not ok 20 - traces-in-t-throws › throwsAsync different error
not ok 21 - traces-in-t-throws › throwsAsync different error
---
name: AssertionError
assertion: throwsAsync
Expand All @@ -228,9 +237,9 @@ not ok 20 - traces-in-t-throws › throwsAsync different error
test-tap/fixture/report/regular/traces-in-t-throws.cjs:27:44
...
---tty-stream-chunk-separator
ok 21 - uncaught-exception › passes
ok 22 - uncaught-exception › passes
---tty-stream-chunk-separator
not ok 22 - Error: Can’t catch me
not ok 23 - Error: Can’t catch me
---
name: Error
message: Can’t catch me
Expand All @@ -239,20 +248,20 @@ not ok 22 - Error: Can’t catch me
(test-tap/fixture/report/regular/uncaught-exception.cjs:5:9)
...
---tty-stream-chunk-separator
not ok 23 - uncaught-exception.cjs exited with a non-zero exit code: 1
not ok 24 - uncaught-exception.cjs exited with a non-zero exit code: 1
---tty-stream-chunk-separator
ok 24 - unhandled-rejection › passes
ok 25 - unhandled-rejection › passes
---tty-stream-chunk-separator
ok 25 - unhandled-rejection › unhandled non-error rejection
ok 26 - unhandled-rejection › unhandled non-error rejection
---tty-stream-chunk-separator
not ok 26 - Error: Can’t catch me
not ok 27 - Error: Can’t catch me
---
name: Error
message: Can’t catch me
at: 'passes (test-tap/fixture/report/regular/unhandled-rejection.cjs:4:17)'
...
---tty-stream-chunk-separator
not ok 27 - unhandled-rejection
not ok 28 - unhandled-rejection
---
message: Non-error object
formatted: 'null'
Expand All @@ -263,6 +272,6 @@ not ok 27 - unhandled-rejection
# tests 20
# pass 6
# skip 1
# fail 20
# fail 22

---tty-stream-chunk-separator
Loading