Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix LUT calibration for grabber-less build configuration #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
satgit62 wants to merge 2 commits into from
Closed

Fix LUT calibration for grabber-less build configuration #809

satgit62 wants to merge 2 commits into from

Conversation

@satgit62
Copy link

@satgit62 satgit62 commented Mar 29, 2024

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@satgit62 satgit62 closed this Mar 29, 2024
@awawa-dev
Copy link
Owner

awawa-dev commented Mar 29, 2024

Something is wrong?

@satgit62
Copy link
Author

satgit62 commented Apr 1, 2024

Hello,

I was wondering if I should make this change to be able to calibrate the LUT under webOS?

#518 (comment)

_lutCalibrator->incomingCommand(_instanceManager->getRootPath(), (_videoGrabber != nullptr) ? _videoGrabber->grabberWrapper() : nullptr, getActiveComponent(), checksum, _startColor, _endColor, limitedRange, saturation, luminance, gammaR, gammaG, gammaB, coef);

@awawa-dev
Copy link
Owner

awawa-dev commented Apr 2, 2024

Yes, if the grabber is excluded from build process completely (for example: webOS) then this patch is necessary. You can re-open PR and I will merge it later.

@satgit62 satgit62 reopened this Apr 2, 2024
@satgit62
Copy link
Author

satgit62 commented Apr 2, 2024

Hi, thanks for quick reply, I have reopened the PR for this change: _lutCalibrator->incomingCommand(_instanceManager->getRootPath(), (_videoGrabber != nullptr) ? _videoGrabber->grabberWrapper() : nullptr, getActiveComponent(), checksum, _startColor, _endColor, limitedRange, saturation, luminance, gammaR, gammaG, gammaB, coef);

@awawa-dev awawa-dev changed the title Update HyperAPI.cpp Fix LUT calibration for grabber-less build configuration Apr 3, 2024
@satgit62 satgit62 closed this by deleting the head repository Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@satgit62 @awawa-dev