fix: improve settings list display #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingfeli
reviewed
Oct 15, 2025
crates/chat-cli/src/cli/settings.rs
Outdated
| /// Open the settings file | ||
| Open, | ||
| /// List all the settings | ||
| /// List all available settings with their descriptions and current values |
Contributor
There was a problem hiding this comment.
I think the biggest change here is the fact that it lists all the settings rather than the formatting.
Let me ask the team to see how people feel about that.
Contributor
There was a problem hiding this comment.
I'd be interested in knowing all the available settings, but would want a way to see just the ones that I have modified/enabled
q settings list
q settings list --all
where current q settings all = q settings list
and what the CR proposes would go under q settings list --all
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback. I modified the command to display both all available settings and the settings users have enabled.
# configured settings
$ q settings list
# all available settings
$ q settings list --all
# backward compatible (q settings all = q settings list)
$ q settings all
dingfeli
approved these changes
Oct 15, 2025
kkashilk
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A(But I often hear users say they don't know how to view the full list of settings.)Description of changes:
I think it would improve the UX if the q settings all command displayed all settings and only highlighted the ones that were changed as shown in the attached image.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.