fix: save convo with context #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensave
approved these changes
Oct 22, 2025
kkashilk
reviewed
Oct 22, 2025
Comment on lines
+115
to
+116
| existing_paths | ||
| .push(ContextFilePath::Session(incoming_path.get_path_as_str().to_string())); |
Contributor
There was a problem hiding this comment.
we should also check if incoming_path was a session-path?
Contributor
Author
There was a problem hiding this comment.
They are all deserialized as Agent path actually. So it is included in here.
evanliu048
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2652
#2912
Description of changes:
As titled.
Note that when loading convo with saved context, we are going to do the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.