Fix knowledge migration moving agent directories #3225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3148
Problem
The
migrate_legacy_knowledge_basefunction was incorrectly moving other agent directories into the current agent's directory when running/knowledge show. This created nested directory structures like:Root Cause
The migration logic didn't distinguish between files and directories when filtering entries in the knowledge_bases root. It was treating other agent directories as "legacy files" to migrate.
Solution
Added a check to ensure only FILES are migrated from the root directory, leaving other agent directories untouched.
Testing
path.is_file()before migrating