fix(amplify): unable to re-run integ test due to missing `status` field in `customRule` #33973

mazyu36 · 2025-03-29T14:30:05Z

Issue # (if applicable)

N/A

I found this problem while working on #33962.

Reason for this change

Re-running packages/@aws-cdk/aws-amplify-alpha/test/integ.app.ts, got the following error:

Resource handler returned message: "Invalid request provided: Status field in rewrite custom rules should not be empty (Service: Amplify, Status Code: 400, Request ID: 3f3694f1-3eeb-4af3-8cdf-8b77b6387e57) (SDK Attempt Count: 1)" (RequestToken: 5748aef8-c0e1-1a1d-ab27-1bab938e0bd3, HandlerErrorCode: InvalidRequest)

If status is omitted in customRules, App cannot be deployed.

Description of changes

Specify status property in integ test.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Re-ran integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mazyu36 · 2025-03-29T14:34:43Z

I'm not sure whether the status property should be changed to required or not.

In Management Console, this property appears to be required.

But in CFn docs, this property is optional.

Considering the possibility that it was optional in the past, I have left it as is.

codecov · 2025-03-29T14:39:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (14442bd).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33973   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112

Flag	Coverage Δ
suite.unit	`83.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`83.98% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

badmintoncryer

Thank you for your contribution! I've added just a comment.

Can we deploy App with CustomRule without specifying status?
This means that is it possible that the CloudFormation documentation is incorrect?

badmintoncryer · 2025-04-05T15:42:51Z

packages/@aws-cdk/aws-amplify-alpha/test/integ.app.ts

+
+new IntegTest(app, 'cdk-amplify-app-integ', {
+  testCases: [stack],
+  enableLookups: true,


I'm curious that why is it needed to enable enableLookups?

Thanks.
This is not needed. I've removed.

mazyu36 · 2025-04-06T11:40:47Z

Thank you for the review.

Can we deploy App with CustomRule without specifying status?

At the moment, this cannot be deployed.
I've encountered the following error.

Resource handler returned message: "Invalid request provided: Status field in rewrite custom rules should not be empty (Service: Amplify, Status Code: 400, Request ID: 3f3694f1-3eeb-4af3-8cdf-8b77b6387e57) (SDK Attempt Count: 1)" (RequestToken: 5748aef8-c0e1-1a1d-ab27-1bab938e0bd3, HandlerErrorCode: InvalidRequest)

Since the previous integ could be deployed, this may be due to a change in Amplify's behavior, but I'm not sure.
I plan to submit an issue to https://github.com/aws-cloudformation/cloudformation-coverage-roadmap.

badmintoncryer

Thank you for your assistance!

paulhcsun · 2025-04-07T21:56:53Z

@Mergifyio update

mergify · 2025-04-07T21:57:13Z

update

✅ Branch has been successfully updated

mergify · 2025-04-07T21:57:14Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-07T22:27:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-07T22:31:17Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-04-07T23:44:31Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 14442bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-07T23:44:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-07T23:44:57Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

fix integ

0d6457c

aws-cdk-automation requested a review from a team March 29, 2025 14:30

github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Mar 29, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 29, 2025

github-actions bot mentioned this pull request Apr 1, 2025

Monthly PR metrics report #33994

Closed

mazyu36 added 2 commits April 4, 2025 08:45

Merge branch 'main' into fix/amplify-custom-rule

82203dd

Merge branch 'main' into fix/amplify-custom-rule

19aabe3

badmintoncryer reviewed Apr 5, 2025

View reviewed changes

update

8bb79ad

badmintoncryer approved these changes Apr 6, 2025

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 6, 2025

paulhcsun approved these changes Apr 7, 2025

View reviewed changes

Merge branch 'main' into fix/amplify-custom-rule

95b7e05

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 7, 2025

Merge branch 'main' into fix/amplify-custom-rule

14442bd

mergify bot merged commit 6638c08 into aws:main Apr 7, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025

mazyu36 deleted the fix/amplify-custom-rule branch April 8, 2025 13:17

fix(amplify): unable to re-run integ test due to missing status field in customRule #33973

fix(amplify): unable to re-run integ test due to missing status field in customRule #33973

Uh oh!

Conversation

mazyu36 commented Mar 29, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

mazyu36 commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

badmintoncryer left a comment

Choose a reason for hiding this comment

Uh oh!

badmintoncryer Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

mazyu36 Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

mazyu36 commented Apr 6, 2025

Uh oh!

badmintoncryer left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun commented Apr 7, 2025

Uh oh!

mergify bot commented Apr 7, 2025

✅ Branch has been successfully updated

Uh oh!

mergify bot commented Apr 7, 2025

Uh oh!

mergify bot commented Apr 7, 2025

Uh oh!

mergify bot commented Apr 7, 2025

Uh oh!

aws-cdk-automation commented Apr 7, 2025

AWS CodeBuild CI Report

Uh oh!

Uh oh!

mergify bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

fix(amplify): unable to re-run integ test due to missing `status` field in `customRule` #33973

fix(amplify): unable to re-run integ test due to missing `status` field in `customRule` #33973

mazyu36 commented Mar 29, 2025 •

edited

Loading

codecov bot commented Mar 29, 2025 •

edited

Loading