[feat: invoke] add Cloud runner support for invoke operation#44
[feat: invoke] add Cloud runner support for invoke operation#44zhongkechen merged 1 commit intomainfrom
Conversation
maschnetwork
left a comment
There was a problem hiding this comment.
Minor comment. Otherwise LGTM.
| } | ||
| } | ||
|
|
||
| default -> throw new UnsupportedOperationException("Unknown operation: " + eventType); |
There was a problem hiding this comment.
Do we need default here? The switch/case should catch all possible values already and we will have the benefit of knowing at build time in case we are missing anything.
There was a problem hiding this comment.
This doesn't throw a compile error if we missed an enum. I think it's because this isn't a switch expression.
There was a problem hiding this comment.
This doesn't throw a compile error if we missed an enum.
I think as long as we throw the UnsupportedOperationException here that is fine since this will force us to implement anyway 👍
I think it's because this isn't a switch expression.
No sure if I understand correctly since we are in a switch(eventType) here
There was a problem hiding this comment.
I tried to left out some enum values and the compiler didn't throw an exception unless I add yield to each case. I think this switch isn't considered a switch expression.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#18
Description
Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? N/A
Integration Tests
Have integration tests been written for these changes? Added a new case
Examples
Has a new example been added for the change? (if applicable) N/A