Codestin Search App

maschnetwork · 2026-01-15T16:54:13Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

#4

Description

Added DurableLogger for logging within a durable execution (Replay awareness and step context)
Added examples with logging and proper MDC log configuration
Cleaned up SDKs own internal logs and move verbose things to TRACE

Checklist

I have filled out every section of the PR template
I have thoroughly tested this change

Testing

Unit Tests

Yes

Integration Tests

Yes

Examples

Yes

zhongkechen · 2026-01-15T22:49:52Z

docs/design.md

+
+`ExecutionManager` tracks whether we're replaying completed operations or executing new ones via `ExecutionMode`:
+
+- **REPLAY**: Started with if `operations.size() > 1` (has checkpointed operations beyond the initial EXECUTION op)


Does this check cover all the scenarios? Python SDK has a method for the same purpose but the condition is much more complex than this https://github.com/aws/aws-durable-execution-sdk-python/blob/afd40835f66a4d2267d4397031cb115e6556f65c/src/aws_durable_execution_sdk_python/state.py#L293-L324

I used the approach that the TS SDK is following:
https://github.com/aws/aws-durable-execution-sdk-js/blob/155c5b88e4419b554039b5869666815d731ba7e6/packages/aws-durable-execution-sdk-js/src/context/execution-context/execution-context.ts#L61-L64

This is just for setting the initial REPLAY state. We do have another method that checks for transitioning back to new in getOperationAndUpdateReplayState - similar how the Python SDK does it. But Python is also checking for Status - which TS is not doing: https://github.com/aws/aws-durable-execution-sdk-js/blob/155c5b88e4419b554039b5869666815d731ba7e6/packages/aws-durable-execution-sdk-js/src/context/durable-context/durable-context.ts#L209

Changed to include terminal state. Please take a look @zhongkechen

phipag

Awesome work @maschnetwork. Just left a few smaller comments below.

It is not clear to me when we use .trace() vs. .debug() now in our library code.

examples/pom.xml

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java

sdk/src/test/java/com/amazonaws/lambda/durable/logging/DurableLoggerTest.java

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java

examples/src/main/java/com/amazonaws/lambda/durable/examples/LoggingExample.java

maschnetwork · 2026-01-19T12:17:55Z

Awesome work @maschnetwork. Just left a few smaller comments below.

It is not clear to me when we use .trace() vs. .debug() now in our library code.

Addressed review comments in latest commit.

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java

sdk/src/main/java/com/amazonaws/lambda/durable/logging/DurableLogger.java

examples/src/main/resources/log4j2.xml

…rminal ops

maschnetwork · 2026-01-20T11:46:11Z

@phipag and @zhongkechen updated the PR to:

Use MDC directly instead of a custom ThreadLocal, improving performance by setting context once per operation rather than per log call. This is still depending on the context creation being moved to handler thread - otherwise MDC would be set on the main thread and not logged for non-step threads
Replay mode now transitions to execution mode when encountering non-terminal operations (not just missing ones)

phipag

Awesome! I like the way we were able to simplify!

docs/design.md

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java

sdk/src/main/java/com/amazonaws/lambda/durable/operation/StepOperation.java

phipag · 2026-01-20T14:20:25Z

A general comment: Should we consider updating all example to use DurableLogger by default with a nice log4j2.xml JSON logging config? The logging example does not add a lot of value because logging is a cross-cutting concern across the whole code base.

maschnetwork · 2026-01-20T20:06:38Z

A general comment: Should we consider updating all example to use DurableLogger by default with a nice log4j2.xml JSON logging config? The logging example does not add a lot of value because logging is a cross-cutting concern across the whole code base.

Yes but lets update the samples in a separate PR and also once your thread naming is merged.

Please check if there are any remaining issues from your side before merging.

phipag

Final changes. Everything else looks good!

examples/pom.xml

examples/src/main/resources/log4j2.xml

phipag

Nice work! 🥳

maschnetwork added 2 commits January 15, 2026 13:52

Implemented logging

21f834a

Formatting

6ec44b2

maschnetwork requested a review from phipag January 15, 2026 16:54

zhongkechen reviewed Jan 15, 2026

View reviewed changes

phipag requested changes Jan 18, 2026

View reviewed changes

phipag reviewed Jan 18, 2026

View reviewed changes

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java Show resolved Hide resolved

phipag reviewed Jan 19, 2026

View reviewed changes

examples/src/main/java/com/amazonaws/lambda/durable/examples/LoggingExample.java Show resolved Hide resolved

Addressed review comments for logger

13b4e0f

phipag reviewed Jan 19, 2026

View reviewed changes

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java Outdated Show resolved Hide resolved

sdk/src/main/java/com/amazonaws/lambda/durable/logging/DurableLogger.java Show resolved Hide resolved

phipag reviewed Jan 19, 2026

View reviewed changes

examples/src/main/resources/log4j2.xml Show resolved Hide resolved

maschnetwork added 4 commits January 20, 2026 12:33

Use MDC Thread Local Approach, use new isReplayingMode and tests

5c4b078

Add ExecutionManagerTest for replay mode transition logic

59d3568

Formatting

b15c2e7

Update design.md: MDC-based logging, replay mode transition on non-te…

2670530

…rminal ops

phipag reviewed Jan 20, 2026

View reviewed changes

docs/design.md Show resolved Hide resolved

sdk/src/main/java/com/amazonaws/lambda/durable/execution/ExecutionManager.java Show resolved Hide resolved

sdk/src/main/java/com/amazonaws/lambda/durable/operation/StepOperation.java Outdated Show resolved Hide resolved

Switch deregister/clearContext order, add JSON logging for examples

41607bc

phipag requested changes Jan 21, 2026

View reviewed changes

examples/pom.xml Show resolved Hide resolved

examples/src/main/resources/log4j2.xml Show resolved Hide resolved

Applied review comments

856e2a6

phipag approved these changes Jan 21, 2026

View reviewed changes

maschnetwork merged commit b95c5bf into main Jan 21, 2026
2 checks passed

maschnetwork deleted the feat/durable-logger branch January 21, 2026 12:33

phipag mentioned this pull request Jan 21, 2026

[Feature]: Add context.logger for structured logging with execution metadata #4

Closed


		`ExecutionManager` tracks whether we're replaying completed operations or executing new ones via `ExecutionMode`:

		- REPLAY: Started with if `operations.size() > 1` (has checkpointed operations beyond the initial EXECUTION op)

Conversation

maschnetwork commented Jan 15, 2026

Issue Link, if available

Description

Checklist

Testing

Unit Tests

Integration Tests

Examples

Uh oh!

zhongkechen Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

maschnetwork Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

maschnetwork Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

maschnetwork Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

phipag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maschnetwork commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maschnetwork commented Jan 20, 2026

Uh oh!

phipag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phipag commented Jan 20, 2026

Uh oh!

maschnetwork commented Jan 20, 2026

Uh oh!

phipag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

phipag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

phipag left a comment •

edited

Loading