bugfix for SDE lib h2c buffers mem unmap #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @itaibak - thanks for the fix! We're vetting it for functionality and will get back to you shortly. |
DavidLiuAmzn
approved these changes
May 28, 2025
|
Thanks again for your contribution, @itaibak! |
monological
pushed a commit
to monological/aws-fpga
that referenced
this pull request
Jun 7, 2025
monological
pushed a commit
to monological/aws-fpga
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the for loop count from
c2h_num_bufferstoh2c_num_buffersas this section refer to the unmap of the h2c buffers.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.