Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

simonmarty
Copy link
Contributor

@simonmarty simonmarty commented Aug 21, 2024

Issue #, if available:

Description of changes: Follow up on convo in #26

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (11c92f2) to head (0f5969b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          14       14           
  Lines        2887     2887           
  Branches       11        9    -2     
=======================================
  Hits         1989     1989           
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dhinakk dhinakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonmarty simonmarty merged commit 2081106 into main Aug 21, 2024
@simonmarty simonmarty deleted the simonmarty-patch-1 branch August 21, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants