Adding cache refresh logic with new URL RefreshNow parameter #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Issue #, if available:* Closes 12 *Description of changes:* Supports new refreshNow parameter in URL requests to the agent, setting this parameter to true will call Secrets Manger to get latest value of secret By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
simonmarty
previously approved these changes
Feb 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 40.79% 42.07% +1.28%
==========================================
Files 15 15
Lines 8541 8598 +57
==========================================
+ Hits 3484 3618 +134
+ Misses 5057 4980 -77 ☔ View full report in Codecov by Sentry. |
simonmarty
approved these changes
Feb 10, 2025
joebaro
approved these changes
Feb 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Closes 12
Description of changes:
Supports new refreshNow parameter in URL requests to the agent, setting this parameter to true will call Secrets Manger to get latest value of secret
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.