feat: FIPS support #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 42.06% 41.67% -0.40%
==========================================
Files 14 14
Lines 8969 9076 +107
==========================================
+ Hits 3773 3782 +9
- Misses 5196 5294 +98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThirdEyeSqueegee
commented
Apr 4, 2025
ThirdEyeSqueegee
commented
Apr 4, 2025
ThirdEyeSqueegee
commented
Apr 4, 2025
There was a problem hiding this comment.
Note: The PR includes two new actions:
seanmiddleditch/gha-setup-ninja@v6:aws-lc-fips-sysrequires Ninja to build on Windowsactions/setup-go@v5:aws-lc-fips-sysrequires Go to build on macOS
The former needs to be added to the allowlist to unblock the build workflow. aws-lc-rs uses this action in their fips workflow so it should be fine to add
|
Allowlisted |
|
Note: Also allowlisted |
simonmarty
approved these changes
Apr 15, 2025
JoeJesse
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
fipswhich uses therustls/fipsfeature to restrict cipher suites to only FIPS-approved ciphers when enabled.TLS
supported_groupswithfipsdisabled:TLS
supported_groupswithfipsenabled:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.