fix: encode bytes before filtering empty text in message_to_payload #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _filter_empty_text function was applied to the raw session_message.message which contains unencoded bytes. This caused json.dumps() to fail with 'Object of type bytes is not JSON serializable' when messages contained image data (e.g., tool results with screenshots or diagrams). The fix reorders the operations to call to_dict() first (which encodes bytes to base64 via encode_bytes_values()), then applies _filter_empty_text to the already-encoded message. Fixes aws#198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
TypeError: Object of type bytes is not JSON serializableerror inmessage_to_payloadwhen messages contain binary data (e.g., images from tool results).Problem
The
_filter_empty_textfunction was applied tosession_message.message(which contains raw bytes) beforeto_dict()was called. The filtered message (with raw bytes) then overwrote the encoded version, causingjson.dumps()to fail.Solution
Reorder operations to:
to_dict()first (encodes bytes to base64)_filter_empty_textto the encoded messageTesting
Verified with test script that:
_filter_empty_text)message_to_payloadwith image bytes)Fixes #198