fix(ci): adding set -e to prevent nix develop to hide failing tests #5393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Jul 2, 2025
goatgoose
reviewed
Jul 2, 2025
* sorry that I misread the file
goatgoose
reviewed
Jul 2, 2025
goatgoose
approved these changes
Jul 3, 2025
jouho
approved these changes
Jul 3, 2025
dougch
pushed a commit
to dougch/s2n-tls
that referenced
this pull request
Jul 9, 2025
…ws#5393) Co-authored-by: Boquan Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
We discovered that our
Integv2NixBatchjob is always passing, although we found that there are failures among those tests. We found out that this is because we didn't addset -ecommand beforenix develop, so that as long as the following command in the phase passes, then the phase overall will pass. We should addset -ebefore all commands that involvenix develop, so that it won't hide any failure.To root cause this problem, we delete the UV test command and only run the INVEGV2 TEST, and the codebuild job failed, such change can be found in #5391.
We also detected that the
dynamic_record_sizestest is silently failing, but the test is meant to be skipped for nix:s2n-tls/codebuild/spec/buildspec_integv2_nix.yml
Lines 18 to 19 in 3ebd384
The reason is we have a typo in the code where the list of tests to be ran is called
INTEGV2_TEST, but the one in the command isINTEGV2_TESTS. So I need to fix the typo.Call-outs:
Testing:
We have tested by adding
set -ecommand in #5392. The test will failed even with the UV test, which is the expected behavior.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.