Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Jul 17, 2025

Release Summary:

Description of changes:

For kTLS, we're using reserved instances, which unlike docker containers, don't get discarded and cleaned up. This has lead to some out of space failures. Add in a nix store gc to clean the nix store prior to refreshing from cache.

Call-outs:

If we expand the use of reserved instances, this cleanup should probably be moved into a central location.

Weekly is a guess, based on the infrequent errors seen in the past, and it might need adjustment.
While regular docker containers with CodeBuild log disk metrics (StorageReadBytes, StorageWriteBytes), the reserved fleets don't appear to provide such metrics (no documentation found).

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? ad-hoc
How can you convince your reviewers that this PR is safe and effective? Some runtime metrics will prove we're not impacting runtimes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jul 17, 2025
@dougch dougch requested a review from CarolYeh910 July 17, 2025 22:52
@dougch dougch marked this pull request as ready for review July 17, 2025 23:24
@dougch dougch requested a review from jmayclin July 17, 2025 23:24
@dougch dougch requested a review from jmayclin July 22, 2025 00:20
@dougch dougch added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@dougch dougch added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@dougch dougch added this pull request to the merge queue Jul 31, 2025
Merged via the queue into aws:main with commit 13a6bdc Jul 31, 2025
50 checks passed
@dougch dougch deleted the nix_gc branch July 31, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants