test(bench): add api for mutual auth handshake #5437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Jul 24, 2025
| fn mutual_auth(&self) -> bool { | ||
| let handshake_type = self.connection.handshake_type().unwrap(); | ||
| assert!(handshake_type.contains("NEGOTIATED")); | ||
| handshake_type.contains("CLIENT_AUTH") |
There was a problem hiding this comment.
I think CLIENT_AUTH can appear when a client certificate message is sent containing no certificate? I think we'd still want to indicate no mutual auth in that case?
If this is the case, maybe checking client_cert_used() is better?
* use client_cert_used instead of checking the handshake type
goatgoose
approved these changes
Jul 24, 2025
Co-authored-by: Sam Clark <[email protected]>
maddeleine
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add an API surfacing whether a handshake used mutual auth, and use that in tests.
Why
Our benchmarks don't currently assert on the handshake type. This is a gap in testing.
How
We add a new method to the
TlsInfotrait, and implement it for all of the implementations.Testing
I added the assertions to the "all handshakes" test.
Related
Related to the rust integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.