feat: add integration test for secp384r1_mlkem_1024 #5438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Jul 25, 2025
jmayclin
approved these changes
Jul 28, 2025
jmayclin
reviewed
Jul 28, 2025
jmayclin
reviewed
Jul 28, 2025
lrstewart
approved these changes
Jul 28, 2025
|
|
||
| #[cfg(feature = "pq")] | ||
| mod mldsa; | ||
| mod pq; |
There was a problem hiding this comment.
This is probably fine for a temporary hack, but it seems sad that we have an entire "features" folder but we're going to shove all the features into one module. If we had a third feature that wasn't pq, what would we rename this module to? "misc"? The more correct way to handle this would probably be to move any code you need to reuse out of mldsa so you can have a separate mlkem file specifically for mlkem tests.
lrstewart
reviewed
Jul 28, 2025
lrstewart
reviewed
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #5432
Description of changes:
Adds integration tests for validating ML-KEM hybrid key exchange interoperability between s2n-tls and OpenSSL 3.5.
Previously, there were no automated tests verifying negotiation of the
SecP384r1MLKEM1024KEM group between s2n-tls and OpenSSL clients/servers. This PR adds two integration tests:These tests confirm a successful handshakes and verifies the negotiated KEM group
SecP384r1MLKEM1024.Call-outs:
Adding integration tests for PR #5395
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.