ci: don't include tls/extensions in SAW build #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
approved these changes
Aug 14, 2025
jouho
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
I noticed while debugging my SAW issues with #5464 that we only build the small subset of files in the "tls" folder that SAW actually needs:
s2n-tls/tls/Makefile
Lines 22 to 23 in 6dcbffe
But we automatically build all the files in "tls/extensions". This is unnecessary-- the SAW proofs don't need any of the extensions code. It just potentially complicates the build and makes the build take longer. Every file we add to the SAW build increases the potential for strange, development-blocking errors.
Testing:
CI still passes, including the SAW build in s2nGeneralBatch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.