Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jun 20, 2025

Please provide the issue number

Issue number:#908

Summary

Changes

This PR adds tests to ensure that Protobuf payloads with magic numbers are processed correctly.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests label Jun 20, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 20, 2025
@hjgraca hjgraca changed the title eat(kafka): add logic to handle protobuf deserialization feat(kafka): add logic to handle protobuf deserialization Jun 20, 2025
@github-actions github-actions bot added the feature New features or minor changes label Jun 20, 2025
@hjgraca hjgraca linked an issue Jun 20, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.26%. Comparing base (67c2a9e) to head (376ae66).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
....Powertools.Kafka/PowertoolsKafkaSerializerBase.cs 87.64% 2 Missing and 9 partials ⚠️
...afka.Protobuf/PowertoolsKafkaProtobufSerializer.cs 90.32% 1 Missing and 2 partials ⚠️
...rtools.Kafka.Json/PowertoolsKafkaJsonSerializer.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #909      +/-   ##
===========================================
+ Coverage    77.15%   77.26%   +0.10%     
===========================================
  Files          272      272              
  Lines        10846    10810      -36     
  Branches      1263     1264       +1     
===========================================
- Hits          8368     8352      -16     
+ Misses        2068     2046      -22     
- Partials       410      412       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hjgraca hjgraca merged commit 3660b0a into develop Jun 20, 2025
3 checks passed
@hjgraca hjgraca deleted the feat/kafka-consumer-proto-schemas branch June 20, 2025 18:09
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or minor changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support Confluent producers in new Kafka utility
2 participants